Skip to content

Add preview for 3d models#123

Open
IshwaryaM1030 wants to merge 5 commits intoversion-15from
preview-3D-model
Open

Add preview for 3d models#123
IshwaryaM1030 wants to merge 5 commits intoversion-15from
preview-3D-model

Conversation

@IshwaryaM1030
Copy link
Copy Markdown
Collaborator

@IshwaryaM1030 IshwaryaM1030 commented Mar 18, 2026 •
edited
Loading

Closes #64

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 18, 2026

📝 Draft Changelog Entry

Changelog

3D model file previews are now available. Users can view 3D model files directly in the file preview interface without needing to download them separately.

This changelog entry was automatically generated by the Changelog Generator Action.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 18, 2026 •
edited
Loading

Coverage

Coverage Report
FileStmtsMissCoverMissing
__init__.py11554%13–14, 20–22
commands.py35350%4–6, 9–11, 17–20, 23, 26–27, 49–51, 53–54, 56, 65, 68–72, 75–76, 85–87, 89–90, 92, 94, 97
customize.py25250%4–5, 7, 10–12, 15–22, 27–35, 47–48
hooks.py150100% 
install.py36360%4–7, 10–11, 14–18, 21–27, 30–34, 36–39, 41–49
migration.py19611541%25, 46, 68–69, 88–89, 96, 115, 123–125, 158–159, 161–162, 166–168, 171–172, 187, 196–197, 199–203, 205–210, 212, 219–221, 223, 225–226, 228, 235–236, 238–242, 244–247, 249, 254–257, 259–268, 270–279, 281–282, 284–285, 287–288, 290–294, 298–301, 305, 307–308, 310, 312–314, 317–318, 320–321, 323–329, 331–332, 334, 336
cloud_storage
   __init__.py00100% 
cloud_storage/doctype
   __init__.py00100% 
cloud_storage/doctype/file_association
   __init__.py00100% 
   file_association.py30100% 
cloud_storage/doctype/file_version
   __init__.py00100% 
   file_version.py30100% 
cloud_storage/overrides
   file.py43115164%66, 76, 96, 119, 121, 136, 138, 145–147, 155–156, 171, 176, 183, 198, 231, 241–250, 252–260, 271, 276–277, 285–287, 289, 294, 300, 302, 318, 322, 327, 335–336, 339, 342, 371, 416, 419, 458, 464, 470, 476, 482, 488, 498, 500–502, 506, 514–516, 518, 533, 536, 547–551, 557–558, 560, 583–587, 599–600, 649, 652–661, 668–669, 671–673, 676–677, 682–684, 686, 691–694, 699, 701, 713–714, 716, 721–725, 727, 738–744, 762, 764–765, 768–770, 772–774, 779–780, 786–787, 790–791, 801–804
config
   __init__.py00100% 
   desktop.py330%4, 7–8
   docs.py660%4, 6–8, 12–13
tests
   conftest.py43197%54
   test_file.py173696%89, 174, 208–210, 223
   test_file_preview.py630100% 
   test_local_storage.py610100% 
TOTAL110438365% 

@IshwaryaM1030
Copy link
Copy Markdown
Collaborator Author

IshwaryaM1030 commented Mar 18, 2026

@agritheory For your reference,
Screencast from 2026-03-18 14-47-24.webm

agritheory
agritheory requested changes Mar 19, 2026
View reviewed changes
Copy link
Copy Markdown
Owner

@agritheory agritheory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'd be better if we could preview in the normal PDF/image/etc preview pane, the same as any other doctype. I think the Vue component may be more trouble than its worth with this approach though.

@agritheory agritheory marked this pull request as draft March 19, 2026 13:33
@IshwaryaM1030 IshwaryaM1030 marked this pull request as ready for review March 23, 2026 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@agritheory agritheory agritheory requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add preview for 3d models

2 participants

@IshwaryaM1030 @agritheory